fix: restore monospace font size to 14px in bootstrap theme Fix #19489#20321
Open
MKabaja wants to merge 1 commit into
Open
fix: restore monospace font size to 14px in bootstrap theme Fix #19489#20321MKabaja wants to merge 1 commit into
MKabaja wants to merge 1 commit into
Conversation
Fixes phpmyadmin#19489 - font size regression from 5.2 (~14px) to 6.0 (~12px). Added CSS custom property --font-size-monospace and applied it to CodeMirror and code elements. Signed-off-by: Mateusz <mateusz.kabaja@gmail.com>
MKabaja
force-pushed
the
fix/code-font-size-regression
branch
from
99966e4 to
009ea5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19489
Problem
After migrating to phpMyAdmin 6.0, the monospace/code font size was reduced from the 5.2 default (~14px) to a smaller value (~12px).
Fix
Added CSS custom property
--font-size-monospace: 14pxin_codemirror.scssand applied it to CodeMirror and code elements.Testing
Verified in phpMyAdmin 6.0 with bootstrap theme - font size is now 14px matching 5.2 behavior.
