Fix #20254 - Tree collapses when clicking on a column in nav tree#20292
Open
predictor2718 wants to merge 1 commit into
Open
Fix #20254 - Tree collapses when clicking on a column in nav tree#20292predictor2718 wants to merge 1 commit into
predictor2718 wants to merge 1 commit into
Conversation
…v tree Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20292 +/- ##
============================================
+ Coverage 63.48% 63.53% +0.05%
- Complexity 16077 16081 +4
============================================
Files 676 676
Lines 59905 59928 +23
============================================
+ Hits 38033 38078 +45
+ Misses 21872 21850 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20254.
CommonParams.get('server')returns a number (1);sessionStoragestringifies values, so
storage.serveris"1". Strict equality onnumbervsstringalways fails, so the page-load logic inevent-loader.tsfalls into theelsebranch on every reload — it wipesthe saved tree paths via
treeStateUpdate()and callsNavigation.reload()without them, collapsing the tree.
The bug was latent until 38b796f added
disableAjaxto all nav-treelinks and made every click trigger a full page reload.
Fix: coerce to string before comparing.
Verified end-to-end with Playwright against MySQL 8.