Skip to content

Only hide processes in status Sleep and inactive Daemon #20255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M393 wants to merge 1 commit into
base: QA_5_2
Choose a base branch
from
+2 −2
Open

Only hide processes in status Sleep and inactive Daemon #20255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/classes/Server/Status/Processes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ public function getList(array $params): array
$urlParams['order_by_field'] = $params['order_by_field'];
$urlParams['sort_order'] = $params['sort_order'];
$urlParams['showExecuting'] = $params['showExecuting'];
$sqlQuery = 'SELECT * FROM `INFORMATION_SCHEMA`.`PROCESSLIST` ';
$sqlQuery = 'SELECT * FROM `INFORMATION_SCHEMA`.`PROCESSLIST`';
}

if (! empty($params['showExecuting'])) {
$sqlQuery .= ' WHERE state != "" ';
$sqlQuery .= " WHERE `COMMAND` <> 'Sleep' AND `STATE` <> 'Waiting for next activation'";
Copy link
Copy Markdown
Contributor

@OlafvdSpek OlafvdSpek Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is <> used commonly in pMA rather than != ?

Copy link
Copy Markdown
Contributor Author

@M393 M393 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I prefer <> because it is standardized SQL, but both should work and both are used elsewhere.

Copy link
Copy Markdown
Contributor

@kamil-tekiela kamil-tekiela Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters. They are identical and both are understood.

Copy link
Copy Markdown
Member

@williamdes williamdes Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think != is easier to understand for newcomers or users that audit queries

}

if (! empty($params['order_by_field']) && ! empty($params['sort_order'])) {
Expand Down
Loading