Skip to content

Only hide processes in status Sleep and inactive Daemon#20255

Open
M393 wants to merge 1 commit intophpmyadmin:QA_5_2from
M393:processlist-fix-hidden-active
Open

Only hide processes in status Sleep and inactive Daemon#20255
M393 wants to merge 1 commit intophpmyadmin:QA_5_2from
M393:processlist-fix-hidden-active

Conversation

@M393
Copy link
Copy Markdown
Contributor

@M393 M393 commented Mar 24, 2026

Fixes #20187

Only excludes connections with command Sleep or Status Waiting for next activation (Event scheduler)

Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>

if (! empty($params['showExecuting'])) {
$sqlQuery .= ' WHERE state != "" ';
$sqlQuery .= " WHERE `COMMAND` <> 'Sleep' AND `STATE` <> 'Waiting for next activation'";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is <> used commonly in pMA rather than != ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I prefer <> because it is standardized SQL, but both should work and both are used elsewhere.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters. They are identical and both are understood.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think != is easier to understand for newcomers or users that audit queries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants