Open
Conversation
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Use a separate query to count changed rows. Wrap select query with limit with a select * query which enables paging for the displayed rows. Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #20238 +/- ##
============================================
+ Coverage 49.41% 49.42% +0.01%
+ Complexity 17188 16851 -337
============================================
Files 607 607
Lines 72549 69652 -2897
============================================
- Hits 35850 34428 -1422
+ Misses 36699 35224 -1475
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18941
When the modal is opened it adds
overflow: hiddenstyle to body.After clicking the
Affected rowslink, scrolling was disabled because the modal was not properly closed. Intrduced in #17065x `new`tox *new*to circumvent a sql-parser error