Skip tables that cannot be read#20224
Open
liviuconcioiu wants to merge 1 commit intophpmyadmin:QA_5_2from
Open
Skip tables that cannot be read#20224liviuconcioiu wants to merge 1 commit intophpmyadmin:QA_5_2from
liviuconcioiu wants to merge 1 commit intophpmyadmin:QA_5_2from
Conversation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
williamdes
reviewed
Mar 7, 2026
Comment on lines
844
to
+1122
| @@ -1110,6 +1115,11 @@ public function exportTable( | |||
| $tableObj = new Table($table, $db); | |||
| $nonGeneratedCols = $tableObj->getNonGeneratedColumns(true); | |||
|
|
|||
| // Skip tables that cannot be read | |||
| if ($nonGeneratedCols === []) { | |||
| return; | |||
| } | |||
|
|
|||
Member
There was a problem hiding this comment.
Can you add a warning to the front end ?
Contributor
Author
There was a problem hiding this comment.
Those lines aren't related to export, just copy. Should I remove them?
Also, not sure how to add one, I tried, but I still get an error:
Internal error in .\libraries\classes\Plugins\Export\ExportSql.php#1543
ErrorException: Error reading structure for table test21.1: #1707 - Table rebuild required. Please do "ALTER TABLE `test21.1` FORCE" or dump/reload to fix it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This should fix the export for all other formats, except
SQL, when tables cannot be read. PreviouslyHTMLcontent was added to the exported file. Now, it will skip the tables and only export what can be read.Something similar was done here:
phpmyadmin/libraries/classes/Table.php
Lines 1303 to 1304 in 559587a
phpmyadmin/src/Table/TableMover.php
Lines 452 to 455 in 2f4a40d
Before:
07.03.2026_15.55.46_REC.mp4
After:
07.03.2026_15.53.17_REC.mp4
Related #18028, #18183, #20160
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.