Fix #17452 - Binary logs fetching for super users only#20222
Open
gs71 wants to merge 1 commit intophpmyadmin:QA_5_2from
Open
Fix #17452 - Binary logs fetching for super users only#20222gs71 wants to merge 1 commit intophpmyadmin:QA_5_2from
gs71 wants to merge 1 commit intophpmyadmin:QA_5_2from
Conversation
williamdes
requested changes
Mar 7, 2026
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
While this seems okay from a first glance I think there is cases where the user is not a super user but only has the BINLOG MONITOR privilege
williamdes
reviewed
Mar 7, 2026
| } else { | ||
| $binaryLogs = $this->dbi->fetchResult('SHOW BINARY LOGS', 'Log_name'); | ||
| SessionCache::set('binary_logs', $binaryLogs); | ||
| if ($isSuperUser) { |
Member
There was a problem hiding this comment.
Suggested change
| if ($isSuperUser) { | |
| $binaryLogs = null; | |
| if ($isSuperUser) { |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent a regular user to try to fetch binalry logs, generating useless errors in the SQL errors log file.
Fixes #17452
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.Signed-off-by: Guido Selva guido.selva@gmail.com