Conversation
liviuconcioiu
left a comment
liviuconcioiu
left a comment
There was a problem hiding this comment.
Nice work! Also, you should update the code, since #19957 has been merged.
A few things:
Can you add this so it will be possible to change the separator and indent.
$leaf = new TextPropertyItem(
'separator',
__('Columns separated with:'),
);
$generalOptions->addProperty($leaf);
$leaf = new TextPropertyItem(
'indent',
__('Indent'),
);
$generalOptions->addProperty($leaf);You should also make changes in src\Config\Settings\Export.php so the values can be seen when exporting and also be able to use them from config file
$cfg['Export']['toon_separator'] = '|';
$cfg['Export']['toon_indent'] = 4;Also, can you add a small text to documentation import_export.rst - #export?
Thank you!
faissaloux
force-pushed
the
toon-export
branch
from
5947131 to
5a4add9
Compare
|
@liviuconcioiu @williamdes |
faissaloux
force-pushed
the
toon-export
branch
from
ce5b4eb to
c79b0ce
Compare
liviuconcioiu
left a comment
liviuconcioiu
left a comment
There was a problem hiding this comment.
@faissaloux I left some comments.
- Add support for tab as delimiter - https://toonformat.dev/playground.html
- Renamed from Toon to TOON
faissaloux
force-pushed
the
toon-export
branch
2 times, most recently
from
25ad49f to
440c403
Compare
|
Documentation updated, code rebased. |
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
All good for me, this is ready to merge I think
I will let @kamil-tekiela review one last time
| public function exportRawQuery(string|null $db, string $sqlQuery): void | ||
| { | ||
| if ($db !== null) { | ||
| DatabaseInterface::getInstance()->selectDb($db); |
There was a problem hiding this comment.
There is two calls to getInstance that are deprecated, at first glance I have no idea of what we migrated to.
But other files should say
There was a problem hiding this comment.
Yeah I have checked for this but found that all other classes uses the same deprecated method. I have found that it's ignored so I'll ignore it for this file too.
Should be fixed in another PR.
faissaloux
force-pushed
the
toon-export
branch
from
7ada6d5 to
4bf2943
Compare
kamil-tekiela
left a comment
kamil-tekiela
left a comment
There was a problem hiding this comment.
Code quality-wise it looks ok. It's mostly copied and adapted from other plugins. I did not verify the logic or adherence to spec.
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
faissaloux
force-pushed
the
toon-export
branch
from
d5a1dfd to
6faaca1
Compare
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
Signed-off-by: faissaloux <fwahabali@gmail.com>
6 participants
Resolves #19945