Replace jQuery UI's datetimepicker with tempus-dominus#19727
Draft
MauricioFauth wants to merge 1 commit intophpmyadmin:masterfrom
Draft
Replace jQuery UI's datetimepicker with tempus-dominus#19727MauricioFauth wants to merge 1 commit intophpmyadmin:masterfrom
MauricioFauth wants to merge 1 commit intophpmyadmin:masterfrom
Conversation
williamdes
approved these changes
Jun 5, 2025
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
Do we loose precision support?
can you post screenshots?
Member
Author
Most libraries doesn't support the fraction part. This library uses the Date JS class that only support three digits of precision, which means that it only supports milliseconds and not microseconds. Most datepickers are really awful. This is the least frustrating library that I've found. At least it has support for plugins that I'm probably gonna use it. |
Member
Author
|
And I don't want to replace the current date/time picker with a half-backed one just for the sake of using a "modern" library. If it doesn't work well, I'm going to close this PR. |
MauricioFauth
force-pushed
the
datetimepicker
branch
2 times, most recently
from
ad1845a to
017d2ff
Compare
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
MauricioFauth
force-pushed
the
datetimepicker
branch
from
017d2ff to
0316b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.