Replace Simulate Query dialog with a modal#17065
Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom Sep 16, 2021
Merged
Replace Simulate Query dialog with a modal#17065MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17065 +/- ##
============================================
- Coverage 47.76% 47.63% -0.13%
- Complexity 16204 16544 +340
============================================
Files 490 571 +81
Lines 61956 60233 -1723
============================================
- Hits 29592 28694 -898
+ Misses 32364 31539 -825
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MauricioFauth
requested changes
Sep 14, 2021
Signed-off-by: Saksham Gupta <shucontech@gmail.com> Set Aria hidden to true Signed-off-by: Saksham Gupta <shucontech@gmail.com>
shucontech
force-pushed
the
simulate_query_modal
branch
from
0c435ab to
b58516e
Compare
MauricioFauth
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saksham Gupta shucontech@gmail.com
Description
Replace Simulate Query dialog with a modal
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.