feat: add einsum() with deterministic accumulation and generic contraction kernels - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
NDArray::einsum()— Einstein summation notation with deterministic accumulation order and a generic contraction engine backed by type-generic kernels.Motivation and Context
matmul()anddot()delegate to BLAS, which tiles matrix operations for cache efficiency but produces non-deterministic accumulation order. For pipelines involvingclamp() → log()or similar threshold-sensitive operations, ~10⁻⁷ differences from BLAS tiling can cascade into wrong results.einsum()fills this gap by offering the same operations with fixed canonical loop order, identical output on every run, every platform.What's Changed
einsum(string $subscripts, ?NDArray $other)— two-operand and single-operand Einstein summationeinsum()inPhpMlKit\NDArray\LinalgnamespaceBreaking Changes
None.