feat: add scalar support to minimum() and maximum() - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds scalar argument support to
minimum()andmaximum(), matching the API ofadd(),multiply(), and other element-wise operations.Motivation and Context
minimum()andmaximum()only accepted NDArray arguments, forcing callers to use awkward workarounds like$arr->clamp($value, INF)just to get a per-element floor. Every other element-wise operation (add,subtract,multiply,divide) already supported scalar arguments so this was an inconsistent gap.What's Changed
minimum()andmaximum()now acceptComplex|float|int|NDArray— when a scalar is passed, each array element is compared against that valuendarray_minimum_scalar,ndarray_maximum_scalar) handle all numeric dtypes via element-wise mappingBreaking Changes
None. The NDArray path is unchanged. The new scalar path returns the same dtype as the input array.