feat: add any() and all() logical reduction methods - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
any()andall()boolean reduction methods to NDArrayMotivation and Context
These were the last missing basic reduction operations.
any()andall()are fundamental for boolean array evaluation — checking conditions, validating constraints, and filtering logic. They were tracked in SPEC.md as unimplemented items 8.2.1 and 8.2.2.What's Changed
any.rs,all.rs) with scalar and axis reduction functionsany(?int $axis = null, bool $keepdims = false): bool|NDArray— tests whether any element is trueall(?int $axis = null, bool $keepdims = false): bool|NDArray— tests whether all elements are trueBreaking Changes
None.