Skip to content

fix: fromArray now actually uses the provided shape parameter #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeWithKyrian merged 1 commit into from
Jun 6, 2026
Merged

fix: fromArray now actually uses the provided shape parameter #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Traits/CreatesArrays.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,20 @@ public static function full(bool|Complex|float|int $value, array $shape, ?DType
public static function fromArray(array $data, ?array $shape = null, ?DType $dtype = null): self
{
$shape ??= self::inferShape($data);
$flatData = self::flattenArray($data);

if (empty($flatData)) {
throw new ShapeException('Cannot create array from empty data');
}

$dtype ??= DType::fromArray($data);

return self::array($data, $dtype);
$lib = Lib::get();
$len = \count($flatData);

$handle = self::createTyped($lib, $dtype, $flatData, $shape, $len);

return new self($handle, new ArrayMetadata($shape), $dtype);
}

/**
Expand Down
Loading