feat(linalg): dtype promotion and vector/matrix rules for matmul and dot - #16
Merged
CodeWithKyrian merged 1 commit intoApr 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds dtype promotion for matrix multiply and dot, implements explicit 1D and 2D matrix-multiply shape rules for
matmul, and updates tests and the standalone eigen example so they use the API directly without extra casts or reshapes where those workarounds are no longer needed.Motivation and context
Linear algebra calls should accept the natural combinations of real and complex operands and apply consistent promotion, similar to other binary operations. Vector–matrix products should not require turning vectors into columns or rows by hand when the operation already defines the intended layout. NumPy’s behavior was used as a reference while designing these rules.
What's changed
matmulanddotso operands are evaluated in a common promoted type (e.g. real with complex).matmul: supports 1D and 2D operands with defined rules (including 1D·1D producing a scalar result); rejects operands with more than two dimensions.dot: dtype promotion aligned with other binary ops; existing dimension behavior preserved.astypeorreshapewhere superseded by the new behavior.Breaking changes
None.