Added test for removing node in other session and refreshing#178
Closed
Added test for removing node in other session and refreshing#178
Conversation
| { | ||
| $this->setExpectedException( | ||
| 'PHPCR\PathNotFoundException', | ||
| 'Property bar' |
Member
Author
There was a problem hiding this comment.
Should probably remove this message check - messages are not part of the spec.
Member
There was a problem hiding this comment.
yep, lets not force the message. and only put the expectation right before the line that should trigger the exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncovers issue raised in jackalope/jackalope-doctrine-dbal#323