Skip to content

Added test for removing node in other session and refreshing#178

Closed
dantleech wants to merge 1 commit intomasterfrom
remove_node_other_session
Closed

Added test for removing node in other session and refreshing#178
dantleech wants to merge 1 commit intomasterfrom
remove_node_other_session

Conversation

@dantleech
Copy link
Member

Uncovers issue raised in jackalope/jackalope-doctrine-dbal#323

{
$this->setExpectedException(
'PHPCR\PathNotFoundException',
'Property bar'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably remove this message check - messages are not part of the spec.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, lets not force the message. and only put the expectation right before the line that should trigger the exception

@dbu dbu deleted the branch master November 20, 2022 10:28
@dbu dbu closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants