Conversation
dantleech
force-pushed
the
noerr
branch
3 times, most recently
from
June 14, 2026 18:22
52129cc to
1c50437
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a baseline is used and there is a benchmark that is not in the benchmark then one of two things happens when showing the "difference":
ERRis shown (e.g. when calculating the percentage difference from themem_peakbut it's NULL)rstdev,modeetc).The new
ifoperator allows the case to conditionally show the difference (theaggregate-previewreport handles this correctly already).Before:
After: