Repository navigation
Conversation
Route every metadata validation through validate(), driven by a static map of composed validations, validation methods and field patterns. validate() loads composer.json itself, so it no longer needs a prior get_metadata() call. The single purpose validators become protected and validate_enable() is replaced by the enable composition. PHPBB-15190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes over #4807 by javiexin, rebased on current master and trimmed to the ticket: one validate() entry point that loads composer.json itself, with the single purpose validators made protected (the original docblocks already announced that for 4.0). The version-check rework from the old PR is left out.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-15190