Repository navigation
[ticket/17770] Allow manually triggering smoke test runs - #7118
Merged
Merged
Conversation
|
The attempt to merge branch
This PR is ready to be merged. |
Add a separate workflow that can be triggered manually to run simple test suites as needed. The smoke test runs a small set of tests with one MySQL, PostgreSQL and SQLite job each instead of the complete test matrix. PHPBB-17770
marc1706
force-pushed
the
ticket/17770
branch
from
November 8, 2026 13:08
e67042a to
5f2a171
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The smoke-test matrix declares PostgreSQL/SQLite and MySQL/SQLite jobs with empty Docker images for unused services, causing service setup to fail before any tests run.
2 open issues
What changed in this PR
Adds a manually triggered GitHub Actions smoke-test workflow with a reduced matrix covering MySQL, PostgreSQL, and SQLite.
Changes:
- Adds
workflow_dispatchsupport for on-demand runs. - Defines smoke-test combinations across PHP and database versions.
- Reuses existing setup, lint, functional-test, and unit-test steps.
This pull request requires changes.
| File | Review |
|---|---|
.github/workflows/smoke_tests.yml |
The PostgreSQL and SQLite entries declare MySQL with an empty image, while the MySQL and SQLite entries declare PostgreSQL with an empty image. These invalid service definitions will cause jobs to fail during service setup. Split the database variants into separate jobs or omit unused services. |
Review effort: Lite
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a separate workflow that can be triggered manually to run simple test suites as needed. The smoke test runs a small set of tests with one MySQL, PostgreSQL and SQLite job each instead of the complete test matrix.
PHPBB-17770
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17770