Repository navigation
Conversation
The ai_crawler_bots migration only checked whether a bot with the same name already existed. A board whose administrator had configured one of the seeded agent strings under a different name therefore received a second bot for the same agent, one in the bots group and one in the AI crawlers group. Bots are matched case insensitively against the agent string in phpbb\session, so both entries match the same requests. Skip seeding a bot whose agent string is already configured, and add a migration that removes the duplicates the 3.3.18 migration has already created, keeping the older bot in each case. PHPBB-17735
|
The attempt to merge branch
This PR is ready to be merged. |
marc1706
requested changes
Nov 3, 2026
Compare the agent strings of the bots already configured on the board with the same case insensitive wildcard match phpbb\session applies to the user agent, instead of an exact match after lowercasing. An AI crawler is skipped by the migration, or removed by the cleanup, when an older bot's agent string already matches it. PHPBB-17735
marc1706
reviewed
Nov 5, 2026
marc1706
reviewed
Nov 5, 2026
A bot restricted to an IP address only matches visitors from that address, so it does not stand in for a crawler matched by agent string alone: the migration no longer treats its agent as already configured. The cleanup migration is more conservative as well: it only removes an AI crawler whose agent string exactly matches, case insensitively, that of an older bot, and only when neither bot is restricted to an IP. PHPBB-17735
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17735