[ticket/17568] Add unit selector to avatar filesize setting#6999
Open
JauntyMYT wants to merge 1 commit into
Open
[ticket/17568] Add unit selector to avatar filesize setting#6999JauntyMYT wants to merge 1 commit into
JauntyMYT wants to merge 1 commit into
Conversation
The maximum avatar filesize setting in the ACP was entered and shown in raw bytes, while the user-facing avatar explanation and the parallel attachment settings present the value in KiB/MiB. This made the admin input inconsistent with the units shown to users. Give the avatar filesize field the same Bytes/KiB/MiB selector already used by the attachment settings, converting the selected unit back to bytes on save. PHPBB3-17568
|
The attempt to merge branch
A separate PR will be needed to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum avatar filesize setting in the ACP was entered and shown in raw bytes, while the user-facing avatar explanation and the parallel attachment settings present the value in KiB/MiB. This made the admin input inconsistent with the units shown to users.
This gives the avatar filesize field the same Bytes/KiB/MiB selector already used by the attachment settings (
acp_attachments), converting the selected unit back to bytes on save. It reuses the existingget_formatted_filesize()andsize_select_options()helpers, mirroring themax_filesizehandling inacp_attachments.Tracker: https://tracker.phpbb.com/browse/PHPBB-17568
Testing
Verified manually on a 3.3 board:
6+KiB, previously6144 Bytes).10+MiBstores10485760bytes; the value round-trips on reload.Note: the automated test suite was not run locally, so the "Tests pass" box is left unchecked.