[ticket/17664] Align pagination start values with page boundaries#6998
Open
ECYaz wants to merge 1 commit into
Open
[ticket/17664] Align pagination start values with page boundaries#6998ECYaz wants to merge 1 commit into
ECYaz wants to merge 1 commit into
Conversation
A start value taken from the URL that does not sit on a page boundary highlights the page the value falls into while the item list is offset by the raw value, so the displayed items match no page of the pagination. Snap validated start values to the beginning of their page so the list always shows the page the pagination marks as active. Out of range values keep their current behaviour of landing on the first or last page. PHPBB-17664
|
The attempt to merge branch
A separate PR will be needed to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17664
A start value taken from the URL that does not sit on a page boundary highlights the page the value falls into while the item list is offset by the raw value, so the displayed items match no page of the pagination. Validated start values now snap to the beginning of their page and the list always shows the page the pagination marks as active. Out of range values keep their current behaviour of landing on the first or last page, covered by the existing tests, and new test cases cover the alignment. Verified on a live board that an off boundary start renders the same items as the boundary value and that the jump to post links in viewtopic are unaffected, as they already compute aligned values.