[ticket/17649] Pass function reference to setTimeout in progress popup#6995
Open
ECYaz wants to merge 1 commit into
Open
[ticket/17649] Pass function reference to setTimeout in progress popup#6995ECYaz wants to merge 1 commit into
ECYaz wants to merge 1 commit into
Conversation
Passing a string to setTimeout is an implicit eval, which requires 'unsafe-eval' in a Content Security Policy's script-src directive. Passing the function reference behaves identically and allows board administrators to deploy a stricter policy. This was the only string argument timer call in the codebase. PHPBB-17649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17649
Passing a string to
setTimeoutis an implicit eval, so a Content Security Policy protecting the ACP has to allow'unsafe-eval'inscript-srcjust for this one call. Passing the function reference behaves identically — the popup's one-second poll and its self-close when the parent page finishes were verified unchanged on a live board — and lets administrators deploy a stricter policy. This was the only string-argument timer call in the codebase.