Skip to content

[ticket/17684] Ext catalog bug fixes and security improvements #6988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iMattPro wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ticket/17684] Ext catalog bug fixes and security improvements #6988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2061ca2
[ticket/17684] Ext catalog bug fixes and security improvements
iMattPro Jul 19, 2026
c0f9949
[ticket/17684] Don’t delete ext files when purge on remove is off
iMattPro Jul 20, 2026
04b8f55
[ticket/17684] Add proper docblocks where needed
iMattPro Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions phpBB/adm/style/acp_ext_catalog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ <h1>{{ lang( 'EXTENSIONS_CATALOG') }}</h1>
<fieldset style="clear: both;">
<legend>{{ lang('EXTENSIONS_CATALOG_SETTINGS') }}</legend>
<dl>
<dt><label for="enable_on_install">{{ lang('ENABLE_ON_INSTALL') }}{{ lang('COLON') }}</label></dt>
<dt><label for="enable_on_install">{{ lang('ENABLE_ON_INSTALL') }}{{ lang('COLON') }}</label><br><span>{{ lang('ENABLE_ON_INSTALL_EXPLAIN') }}</span></dt>
<dd>
<label><input type="radio" id="enable_on_install" name="enable_on_install" class="radio" value="1"{% if settings.enable_on_install %} checked="checked" {% endif %} /> {{ lang('YES') }}</label>
<label><input type="radio" name="enable_on_install" class="radio" value="0"{% if not settings.enable_on_install %} checked="checked" {% endif %} /> {{ lang('NO') }}</label>
</dd>
</dl>
<dl>
<dt><label for="purge_on_remove">{{ lang('PURGE_ON_REMOVE') }}{{ lang('COLON') }}</label></dt>
<dt><label for="purge_on_remove">{{ lang('PURGE_ON_REMOVE') }}{{ lang('COLON') }}</label><br><span>{{ lang('PURGE_ON_REMOVE_EXPLAIN') }}</span></dt>
<dd>
<label><input type="radio" id="purge_on_remove" name="purge_on_remove" class="radio" value="1"{% if settings.purge_on_remove %} checked="checked" {% endif %} /> {{ lang('YES') }}</label>
<label><input type="radio" name="purge_on_remove" class="radio" value="0"{% if not settings.purge_on_remove %} checked="checked" {% endif %} /> {{ lang('NO') }}</label>
Expand All @@ -42,6 +42,8 @@ <h1>{{ lang( 'EXTENSIONS_CATALOG') }}</h1>
</dt>
<dd>
<textarea id="repositories" name="repositories" rows="5" cols="30">{{ settings.repositories|join('\n') }}</textarea>
<br />
<input class="button2" type="button" id="restore_default_repositories" value="{{ lang('RESTORE_DEFAULT_REPOSITORIES') }}" title="{{ lang('RESTORE_DEFAULT_REPOSITORIES_EXPLAIN') }}" data-default-repositories="{{ settings.default_repositories|json_encode|e('html_attr') }}" />
</dd>
</dl>
<dl>
Expand Down Expand Up @@ -127,4 +129,20 @@ <h1>{{ lang( 'EXTENSIONS_CATALOG') }}</h1>
</div>
{% endif %}

<script>
// Restore the repository field to phpBB's installed defaults.
(function() {
'use strict';

var restoreButton = document.getElementById('restore_default_repositories');
var repositories = document.getElementById('repositories');

if (restoreButton && repositories) {
restoreButton.addEventListener('click', function() {
repositories.value = JSON.parse(restoreButton.dataset.defaultRepositories).join('\n');
});
}
}());
</script>

{% include('overall_footer.html') %}
Loading
Loading