[ticket/16957] Improve ACP extension explanations and remove HTML#6986
Open
ECYaz wants to merge 1 commit into
Open
[ticket/16957] Improve ACP extension explanations and remove HTML#6986ECYaz wants to merge 1 commit into
ECYaz wants to merge 1 commit into
Conversation
Remove the remaining HTML from the explanation strings on the ACP extensions pages, as they are used as title attributes where HTML is displayed literally. Apply the ticket's wording for the update and remove explanations of composer-managed extensions, and move the extensions catalog alpha warning into the template. PHPBB-16957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
The
EXTENSION_*_EXPLAINlanguage keys are used astitleattributes for theaction links on the extensions list, where any HTML is displayed literally
(see the screenshot in the ticket). This removes the remaining HTML from the
explanation strings on the ACP extensions pages and applies the wording for
composer-managed extensions proposed in the ticket:
EXTENSION_UPDATE_EXPLAINandEXTENSION_REMOVE_EXPLAINnow use theticket's wording — they describe the composer flow (disable, delete files,
upload the most recent compatible release, re-enable), since these two
actions are only offered for catalog-managed extensions.
EXTENSIONS_CATALOG_EXPLAIN(added inPHPBB-17682) moved to a new
EXTENSIONS_CATALOG_WARNINGkey; the warningmarkup now lives in the template, using the same
<strong class="error">{{ lang('WARNING') }}…pattern the page alreadyuses for the packagist and minimum-stability warnings.
<samp>markup inEXTENSION_INSTALLING_EXPLAIN_STEP2andCOMPOSER_MINIMUM_STABILITY_EXPLAINreplaced with typographic quotes.Not touched, deliberately:
EXTENSION_INVALID_LISTandEXTENSION_DELETE_DATA_CONFIRMstill contain<br />— they are an errormessage and a confirm-box message rather than explanation lines, they never
reach a
titleattribute, and confirm-box messages use<br />throughoutthe language files. Happy to include them if preferred.
The functional tests now also assert that no action tooltip on the
extensions list contains HTML, that the composer-managed update and remove
tooltips carry the new explanations, and that the catalog page renders the
explanation and the warning separately.
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-16957