Ticket/17624 Datetime edge case tests fail when local timezone is ahead of UTC#6947
Closed
avandenberghe wants to merge 5 commits intophpbb:masterfrom
Closed
Ticket/17624 Datetime edge case tests fail when local timezone is ahead of UTC#6947avandenberghe wants to merge 5 commits intophpbb:masterfrom
avandenberghe wants to merge 5 commits intophpbb:masterfrom
Conversation
The edge case test data used strtotime('yesterday'/'today'/'tomorrow')
which computes timestamps in the local timezone, then formatted them
with gmdate() which outputs in UTC. When the local timezone is ahead
of UTC, this shifts the date by one day, causing consistent failures.
Replace with time() arithmetic (time() - 86400, time(), time() + 86400)
which is timezone-agnostic and matches the pattern used by the other
test cases in the same data provider.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The edge case test data used strtotime('yesterday'/'today'/'tomorrow')
which computes timestamps in the local timezone, then formatted them
with gmdate() which outputs in UTC. When the local timezone is ahead
of UTC, this shifts the date by one day, causing consistent failures.
Replace with time() arithmetic (time() - 86400, time(), time() + 86400)
which is timezone-agnostic and matches the pattern used by the other
test cases in the same data provider.
…o ticket/17624
avandenberghe
changed the title
The edge case test data used strtotime('yesterday'/'today'/'tomorrow')
which computes timestamps in the local timezone, then formatted them
with gmdate() which outputs in UTC. When the local timezone is ahead
of UTC, this shifts the date by one day, causing consistent failures.
Replace with time() arithmetic (time() - 86400, time(), time() + 86400)
which is timezone-agnostic and matches the pattern used by the other
test cases in the same data provider.
PHPBB-17624
…o ticket/17624
Member
|
Thanks for your PR. I have refactored it to get rid of those not needed merge commits and also switch back to strtotime but with timezone independent calls of e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17624