[ticket/17623] switch twitter to x in profile by Prosk8er · Pull Request #6946 · phpbb/phpbb

Prosk8er · 2026-03-14T00:53:34Z

phpbb3 version of PHPBB-17623

Checklist:

Correct branch: master for new features; 3.3.x for fixes
Tests pass
Code follows coding guidelines: master and 3.3.x
Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-17623

phpbb3 version of PHPBB-17623 PHPBB-17623

github-actions · 2026-03-14T00:54:11Z

The attempt to merge branch 3.3.x into master has completed after considering the changes in this PR.

Merge result: Conflict ❌

A separate PR will be needed to merge 3.3.x into master.

kaileymsnay · 2026-03-14T12:48:56Z

Part of your failure is your commit message for "forgot migration file". You need [ticket/17623] at the front. Same with your other PR.

Prosk8er · 2026-03-14T13:36:49Z

Part of your failure is your commit message for "forgot migration file". You need [ticket/17623] at the front. Same with your other PR.

thanks that was going to be my next try

phpbb3 version of PHPBB-17623 PHPBB-17623

danieltj27

There's still lots of references to Twitter which should be completely changed to say X instead.

Also there needs to be a discussion around the migration schema. I'm pretty sure you should keep old schemas as is and create new ones to update existing data but a second opinion is needed on that.

danieltj27 · 2026-03-26T13:45:49Z

phpBB/install/schemas/schema_data.sql

 INSERT INTO phpbb_profile_fields (field_name, field_type, field_ident, field_length, field_minlen, field_maxlen, field_novalue, field_default_value, field_validation, field_required, field_show_novalue, field_show_on_reg, field_show_on_pm, field_show_on_vt, field_show_on_ml, field_show_profile, field_hide, field_no_view, field_active, field_order, field_is_contact, field_contact_desc, field_contact_url) VALUES ('phpbb_yahoo', 'profilefields.type.string', 'phpbb_yahoo', '40', '5', '255', '', '', '.*', 0, 0, 0, 1, 1, 1, 1, 0, 0, 0, 8, 1, 'SEND_YIM_MESSAGE', 'ymsgr:sendim?%s');
 INSERT INTO phpbb_profile_fields (field_name, field_type, field_ident, field_length, field_minlen, field_maxlen, field_novalue, field_default_value, field_validation, field_required, field_show_novalue, field_show_on_reg, field_show_on_pm, field_show_on_vt, field_show_on_ml, field_show_profile, field_hide, field_no_view, field_active, field_order, field_is_contact, field_contact_desc, field_contact_url) VALUES ('phpbb_facebook', 'profilefields.type.string', 'phpbb_facebook', '20', '5', '50', '', '', '[\w.]+', 0, 0, 0, 1, 1, 1, 1, 0, 0, 1, 9, 1, 'VIEW_FACEBOOK_PROFILE', 'https://facebook.com/%s/');
-INSERT INTO phpbb_profile_fields (field_name, field_type, field_ident, field_length, field_minlen, field_maxlen, field_novalue, field_default_value, field_validation, field_required, field_show_novalue, field_show_on_reg, field_show_on_pm, field_show_on_vt, field_show_on_ml, field_show_profile, field_hide, field_no_view, field_active, field_order, field_is_contact, field_contact_desc, field_contact_url) VALUES ('phpbb_twitter', 'profilefields.type.string', 'phpbb_twitter', '20', '1', '15', '', '', '[\w_]+', 0, 0, 0, 1, 1, 1, 1, 0, 0, 1, 10, 1, 'VIEW_TWITTER_PROFILE', 'https://twitter.com/%s');
+INSERT INTO phpbb_profile_fields (field_name, field_type, field_ident, field_length, field_minlen, field_maxlen, field_novalue, field_default_value, field_validation, field_required, field_show_novalue, field_show_on_reg, field_show_on_pm, field_show_on_vt, field_show_on_ml, field_show_profile, field_hide, field_no_view, field_active, field_order, field_is_contact, field_contact_desc, field_contact_url) VALUES ('phpbb_twitter', 'profilefields.type.string', 'phpbb_twitter', '20', '1', '15', '', '', '[\w_]+', 0, 0, 0, 1, 1, 1, 1, 0, 0, 1, 10, 1, 'VIEW_TWITTER_PROFILE', 'https://x.com/%s');


You need to replace VIEW_TWITTER_PROFILE with VIEW_X_PROFILE although perhaps it needs to be something a bit more unique as that kind of makes it seem like a placeholder. Up for discussion as to whether that's okay as is but it definitely needs changing from Twitter.

danieltj27 · 2026-03-26T13:46:13Z

phpBB/language/en/common.php

 	'AUTH_PROVIDER_OAUTH_SERVICE_FACEBOOK'					=> 'Facebook',
 	'AUTH_PROVIDER_OAUTH_SERVICE_GOOGLE'					=> 'Google',
-	'AUTH_PROVIDER_OAUTH_SERVICE_TWITTER'					=> 'Twitter',
+	'AUTH_PROVIDER_OAUTH_SERVICE_TWITTER'					=> 'X',


Replace with AUTH_PROVIDER_OAUTH_SERVICE_X

danieltj27 · 2026-03-26T13:46:27Z

phpBB/language/en/common.php

 	),
 	'TRACKED_PHP_ERROR'	=> 'Tracked PHP errors: %s',
-	'TWITTER'			=> 'Twitter',
+	'TWITTER'			=> 'X',


Replace language string to X

danieltj27 · 2026-03-26T13:46:50Z

phpBB/language/en/memberlist.php

 	'VIEW_FACEBOOK_PROFILE'	=> 'View Facebook Profile',
 	'VIEW_SKYPE_PROFILE'	=> 'View Skype Profile',
-	'VIEW_TWITTER_PROFILE'	=> 'View Twitter Profile',
+	'VIEW_TWITTER_PROFILE'	=> 'View X Profile',


Replace the word TWITTER

danieltj27 · 2026-03-26T13:48:53Z

phpBB/phpbb/db/migration/data/v33x/profilefields_x_update.php

+
+		$this->db->sql_query(
+			"UPDATE $profile_fields
+				SET field_contact_url = 'https://x.com/%s'


A second opinion is probably wise although I'm pretty sure you shouldn't be changing database migrations. This only adds a custom profile field that can be changed in the ACP anyway. I think the most appropriate way to go about this is to create a new migration (possibly).

danieltj27 · 2026-03-26T13:49:10Z

phpBB/styles/prosilver/theme/colours.css

 .phpbb_facebook-icon					{ background-position: -119px 0; }
 .phpbb_skype-icon					{ background-position: -161px 0; }
-.phpbb_twitter-icon					{ background-position: -203px 0; }
+.phpbb_twitter-icon					{ background-position: -202px 0; }


Change the class name to x-icon and update all instances where it's used.

Crizz0 · 2026-03-26T14:23:55Z

Maybe it is a better idea to remove it instead of renaming.

Prosk8er · 2026-03-26T22:17:35Z

There's still lots of references to Twitter which should be completely changed to say X instead.

Also there needs to be a discussion around the migration schema. I'm pretty sure you should keep old schemas as is and create new ones to update existing data but a second opinion is needed on that.

@danieltj27 i left the vars/strings twitter instead of changing everything to x so its easier to understand what it is plus if i did that there would be a bunch more changes and a single letter for language var like 'X' => 'X', which doesn't seem right to have 1 letter? i could change it all if its deemed necessary

danieltj27 · 2026-03-28T09:52:19Z

@danieltj27 i left the vars/strings twitter instead of changing everything to x so its easier to understand what it is plus if i did that there would be a bunch more changes and a single letter for language var like 'X' => 'X', which doesn't seem right to have 1 letter? i could change it all if its deemed necessary

I don't disagree. Perhaps XCOM would make more sense, it's a bit more descriptive rather than just having X which could be mistaken as a placeholder and changed accidentally.

[ticket/17623] switch twitter to x in profile

0ea3f1d

phpbb3 version of PHPBB-17623 PHPBB-17623

Prosk8er force-pushed the ticket/17623-phpbb3 branch from c2b00e2 to 9c49410 Compare March 14, 2026 11:52

[ticket/17623] forgot migration file

b5b2b00

phpbb3 version of PHPBB-17623 PHPBB-17623

Prosk8er force-pushed the ticket/17623-phpbb3 branch from 9c49410 to b5b2b00 Compare March 14, 2026 13:38

danieltj27 suggested changes Mar 26, 2026

View reviewed changes

Uh oh!

Conversation

Prosk8er commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaileymsnay commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Prosk8er commented Mar 14, 2026

Uh oh!

danieltj27 left a comment

Choose a reason for hiding this comment

Uh oh!

danieltj27 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

danieltj27 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

danieltj27 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

danieltj27 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

danieltj27 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

danieltj27 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Crizz0 commented Mar 26, 2026

Uh oh!

Prosk8er commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danieltj27 commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Prosk8er commented Mar 14, 2026 •

edited

Loading

github-actions bot commented Mar 14, 2026 •

edited

Loading

kaileymsnay commented Mar 14, 2026 •

edited

Loading

Prosk8er commented Mar 26, 2026 •

edited

Loading