Skip to content

[ticket/17551] Docker phpBB development script#6858

Open
CHItA wants to merge 1 commit intophpbb:masterfrom
CHItA:ticket/17551
Open

[ticket/17551] Docker phpBB development script#6858
CHItA wants to merge 1 commit intophpbb:masterfrom
CHItA:ticket/17551

Conversation

@CHItA
Copy link
Copy Markdown
Member

@CHItA CHItA commented Sep 26, 2025

PHPBB3-17551

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-17551

@iMattPro
Copy link
Copy Markdown
Member

I don't think PHPBB_ROOT_PATH should be needed, and it adds complexity to the setup. This script is already inside the repo, so the path to the repo is already known, as it is simply relative to this script... it should just be ../ I believe.

Same with the stuff about editing the hosts file. I don't understand why it wouldn't just be http://localhost:8080 or something like that out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants