Skip to content

Bug-Fix: Edit profile with deactivated Modul Edit profile#6774

Closed
nice42q wants to merge 1 commit intophpbb:masterfrom
nice42q:patch-1
Closed

Bug-Fix: Edit profile with deactivated Modul Edit profile#6774
nice42q wants to merge 1 commit intophpbb:masterfrom
nice42q:patch-1

Conversation

@nice42q
Copy link
Copy Markdown

@nice42q nice42q commented Jan 27, 2025

Removes "&mode=profile_info" &mode=profile_info
If the module (Edit profile) is deactivated in ACP -> System -> Module management -> Profile, the ‘Edit profile’ function no longer works. This change corrects the error.

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

&mode=profile_info
@marc1706
Copy link
Copy Markdown
Member

Can you clarify a bit of what you are trying to fix? If one disables a core module, this can indeed result in some unexpected side effects. Apparently the link not working properly is one of them. However, this seems like a misconfiguration and the change would seemingly break the link for everyone else that does not have this misconfiguration.

@nice42q
Copy link
Copy Markdown
Author

nice42q commented Feb 11, 2025

However, this seems like a misconfiguration and the change would seemingly break the link for everyone else that does not have this misconfiguration.

With the code change, profile editing also works with the active 'Edit profile' module.
phpbb3
The error shown in the video (GIF) will be fixed.

@iMattPro
Copy link
Copy Markdown
Member

The proper solution to this I think would be to not display the "Edit Profile" link if the module is disabled.

@danieltj27
Copy link
Copy Markdown
Member

The proper solution to this I think would be to not display the "Edit Profile" link if the module is disabled.

The same goes for any module that is linked somewhere I guess.

It's a very niche scenario disabling the edit profile module though 🤨

@nice42q nice42q closed this by deleting the head repository Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants