Bug-Fix: Edit profile with deactivated Modul Edit profile#6774
Closed
nice42q wants to merge 1 commit intophpbb:masterfrom
Closed
Bug-Fix: Edit profile with deactivated Modul Edit profile#6774nice42q wants to merge 1 commit intophpbb:masterfrom
nice42q wants to merge 1 commit intophpbb:masterfrom
Conversation
&mode=profile_info
Member
|
Can you clarify a bit of what you are trying to fix? If one disables a core module, this can indeed result in some unexpected side effects. Apparently the link not working properly is one of them. However, this seems like a misconfiguration and the change would seemingly break the link for everyone else that does not have this misconfiguration. |
Author
Member
|
The proper solution to this I think would be to not display the "Edit Profile" link if the module is disabled. |
Member
The same goes for any module that is linked somewhere I guess. It's a very niche scenario disabling the edit profile module though 🤨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Removes "&mode=profile_info"
&mode=profile_infoIf the module (Edit profile) is deactivated in ACP -> System -> Module management -> Profile, the ‘Edit profile’ function no longer works. This change corrects the error.
Checklist: