Skip to content

[ticket/17289] Fix dependency injection error when using development environment#6583

Closed
rubencm wants to merge 1 commit intophpbb:masterfrom
rubencm:ticket/17289
Closed

[ticket/17289] Fix dependency injection error when using development environment#6583
rubencm wants to merge 1 commit intophpbb:masterfrom
rubencm:ticket/17289

Conversation

@rubencm
Copy link
Copy Markdown
Member

@rubencm rubencm commented Feb 11, 2024

Was caused by marc1706@0434bce#diff-bf18b9eb9b4d5a89d960fa845174f2505efb3fb1684b3cdfc22ddf6e02b9c16e

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-17289

@rubencm rubencm force-pushed the ticket/17289 branch 3 times, most recently from 891bbd1 to e0b2ff0 Compare February 11, 2024 20:42
* Index of array in service template.twig.environment inside services_twig.yml
* @var int
*/
const TWIG_OPTIONS_POSITION = 8;
Copy link
Copy Markdown
Member

@iMattPro iMattPro Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update the comment on line 93 (formerly line 89)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants