[ticket/13204] Tell user that password was incorrect when exceeding attempts#3068
Merged
Merged
Conversation
Contributor
|
The idea of not telling the password was wrong is, to not let hackers continue to bruteforce the attack until they got the password. So im not sure this is a good idea |
Collaborator
|
Not sure an extra language entry is needed. If the CAPTCHA is incorrect, say so. Otherwise, if the password is incorrect, say so. |
naderman
force-pushed
the
develop-ascraeus
branch
from
November 2, 2014 00:29
61ad400 to
0e772af
Compare
…ttempts At the end of the login method, the captcha was entered correctly and only the password was incorrect. Therefore, just tell the user that the password was incorrect. He will see that he still needs to enter a captcha. PHPBB3-13204
marc1706
force-pushed
the
ticket/13204
branch
from
November 2, 2014 10:19
5d2ea96 to
0868831
Compare
Member
Author
|
Updated to use the old language entry for telling the user that the password is wrong. |
nickvergessen
added a commit
to nickvergessen/phpbb
that referenced
this pull request
Nov 21, 2014
[ticket/13204] Tell user that password was incorrect when exceeding attempts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.phpbb.com/browse/PHPBB3-13204