Skip to content

[Vim Plugin] Goto reference in a modified file causes warning fixes #477 - #480

Merged
dantleech merged 2 commits into
developfrom
fix_switch_to_file
May 23, 2018
Merged

dantleech merged 2 commits into
developfrom
fix_switch_to_file

Conversation

@dantleech

@dantleech dantleech commented May 22, 2018 •

Copy link
Copy Markdown
Collaborator

Comment thread plugin/phpactor.vim
" >> open_file
if a:actionName == "open_file"
call phpactor#_switchToBufferOrEdit(a:parameters['path'])
exec ":edit"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was here for a reason probably - for cases where the file has been modified on disk and should be reloaded.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cases where this might happen:

  • Replace references in current file
  • Generate method in new file
  • ??

Works on all of the above

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. and if files have been changed on disk, VIM should warn about this.

@dantleech
dantleech merged commit fe340fe into develop May 23, 2018
@dantleech
dantleech deleted the fix_switch_to_file branch May 23, 2018 06:53
zonuexe pushed a commit to zonuexe/phpactor that referenced this pull request Aug 7, 2018
…hpactor#477 (phpactor#480)

* [Vim Plugin] Goto reference in a modified file causes warning fixes phpactor#477

* Fixed Vader test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant