Skip to content

Class import - #351

Merged
dantleech merged 4 commits into
masterfrom
class_import
Mar 30, 2018
Merged

dantleech merged 4 commits into
masterfrom
class_import

Conversation

@dantleech

@dantleech dantleech commented Mar 30, 2018 •

Copy link
Copy Markdown
Collaborator
  • Handle class importing in Phpactor and not in the VIM plugin
  • Will ask for an Alias if the class is already imported

TODO:

  • Currently the code updater makes unnecessary changes (e.g. reformatting method declarations), this should be fixed before merging this as it's a very frequent operation. this was already fixed.

Comment thread lib/Rpc/Handler/ImportClassHandler.php Outdated
$suggestions = $this->suggestions($arguments[self::PARAM_NAME]);
$suggestions = array_map(function (array $suggestion) {
return $suggestion['class'];
}, $suggestions);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this into the method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant