Skip to content

WIP: Generate override for test methods - #3073

Open
mamazu wants to merge 3 commits into
phpactor:masterfrom
mamazu:fix/fixing_testing_method_generation
Open

mamazu wants to merge 3 commits into
phpactor:masterfrom
mamazu:fix/fixing_testing_method_generation

Conversation

@mamazu

@mamazu mamazu commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Fixing the test generation method, test methods are now protected.

@mamazu
mamazu force-pushed the fix/fixing_testing_method_generation branch from 1e635f5 to 655065f Compare October 7, 2026 17:15
@mamazu
mamazu force-pushed the fix/fixing_testing_method_generation branch from 655065f to 9a7d21e Compare October 7, 2026 17:41
@dantleech

Copy link
Copy Markdown
Collaborator

I forgot this was a feature. Why have the test cases been deleted?

@mamazu

mamazu commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

True, we should probably keep them in the first place. However I'm curious why didn't they fail before.

@mamazu
mamazu force-pushed the fix/fixing_testing_method_generation branch from 49d5000 to 509e731 Compare October 7, 2026 22:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants