Skip to content

Code action to add #[Override]#3056

Merged
dantleech merged 1 commit into
phpactor:masterfrom
AJenbo:action-override
Jul 21, 2026
Merged

Code action to add #[Override]#3056
dantleech merged 1 commit into
phpactor:masterfrom
AJenbo:action-override

Conversation

@AJenbo

@AJenbo AJenbo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #2966

(Note I still don't know how to quit Vim so I haven't tried it all out manually, hope the tests makes up for it).

It's a bit late here so let me know if you want me to change anything that I missed.

@AJenbo
AJenbo force-pushed the action-override branch from 9cb92b3 to 2852f08 Compare July 21, 2026 02:45
@AJenbo
AJenbo force-pushed the action-override branch from 2852f08 to fba8ef4 Compare July 21, 2026 02:45
Comment thread CHANGELOG.md

Features:

- Code action / transformer to add missing `#[\Override]` attributes #2966 @ajenbo

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in the top section

@dantleech
dantleech merged commit cb40f25 into phpactor:master Jul 21, 2026
13 checks passed
@dantleech

dantleech commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Thanks! I had been meaning to add this for some time, and it seems to work well 🙂 I'll fix the CHANGELOG in master

@AJenbo
AJenbo deleted the action-override branch July 21, 2026 09:17
@AJenbo

AJenbo commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Once we can upgrade to 8.5 at work (hopefully soon) there's going to be a bunch of files where these needs to be applied so seemed useful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code action to add #[Override]

2 participants