Repository navigation
Ask permission to load .phpactor.json in project root - #2924
Conversation
2eeb58d to
e5679f2
Compare
e5679f2 to
dd2f40d
Compare
dd2f40d to
f1d52a7
Compare
f1d52a7 to
afda5cf
Compare
|
Worked great. May be for convenience have newly created config files trusted by default? As long as there was none before. |
1e270c8 to
c5a6268
Compare
I think there's still a risk there that you |
4d9d406 to
77cb30d
Compare
|
There was an interaction where that makes sense - where phpactor detects psalm and other tooling in composer and asks if they should be enabled. May be that flow should be updated to ask if location should be trusted and if it is recorded as not trusted no request to enable tools should be made afterwards. |
77cb30d to
b37bf38
Compare
In order to mitigate potential arbitrary execution attacks always ask permission before loading a project-level phactor configuration file. - Introduce the concept of trust - Language server to ask permission before allowing configuration files to be loaded. - CLI shows a warning if a configuration file is present but not loaded due to trust issues. - `phpactor config:trust` command introduced to allow setting the trust status of the resolved project root. pFixing tests Unconditional trust env var
b37bf38 to
99ceded
Compare
Yeah ... I've changed it so that auto-config modifies the file regardless but the confirmation text indicates that the config file is not trusted and won't be used. |
0be3170 to
e5480c6
Compare
|
I'll let it in the main branch for a week or so and then tag a new version, thanks! |
In order to mitigate the risk of arbitrary code execution via. a malicious
.phpactor.jsonalways ask permission.