Matching class names case insensitive#2561
Closed
mamazu wants to merge 2 commits intophpactor:masterfrom
Closed
Conversation
| } | ||
|
|
||
| return str_starts_with($record->shortName(), $this->name); | ||
| return str_starts_with(strtolower($record->shortName()), $this->name); |
Contributor
There was a problem hiding this comment.
This place is tempting to try (probably slow) fuzzy matching if str_starts_with didn't match:
Suggested change
| return str_starts_with(strtolower($record->shortName()), $this->name); | |
| if (str_starts_with(strtolower($record->shortName()), $this->name)) { | |
| return true; | |
| } | |
| $regex = '#' . implode('.*', array_map(preg_quote(...), str_split($this->name))) . '#i'; | |
| return preg_match($regex, $record->shortName()) === 1; | |
Contributor
Author
|
Closed replaced by #2562 |
Contributor
|
On simple benchmark in #2563 I see that using a class compound of two Criteria class is significantly slower so closing this PR seems to be good idea in favor of single class implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only changes the behaviour of the ShortName search as searching with an FQN sould be case sensitive. Or what do you think?