@dantleech at the moment it seems to work on simple cases but

• we need to verify if we need the part described in workspace/willRenameFiles - destination file must exist before #2522 (currently commented out)
• I'm aware that it's badly designed at the moment - I mean using WorkspaceEdit directly in FileRenamer. Probably we need to define some equivalent of Phpactor\Rename\Model\LocatedTextEditsMap instead and convert it to WorkspaceEdit in the handler.

To test it with Neovim (master) I use

local function willRenameFilesHandler(response)
  for clientId, clientResponse in pairs(response) do
    local client = vim.lsp.get_client_by_id(clientId)
    if nil == client then
      vim.notify(('Client %s does not exist'):format(clientId), vim.log.levels.ERROR, {title = 'LSP: workspace/willRenameFiles'})

      return
    end

    vim.lsp.util.apply_workspace_edit(clientResponse.result, client.offset_encoding)
    -- vim.print(clientResponse.result)
  end
end

local function willRenameCurrentBuffer(newPath)
  if not vim.startswith(newPath, '/') then
    newPath = vim.fs.joinpath(vim.uv.cwd(), newPath)
  end
  vim.lsp.buf_request_all(
    0,
    'workspace/willRenameFiles', 
    {
      files = { { oldUri = vim.uri_from_bufnr(0), newUri = vim.uri_from_fname(newPath) } },
    },
    willRenameFilesHandler
  )
end
vim.api.nvim_create_user_command('WillRenameCurrentBuffer', function (opts)
  willRenameCurrentBuffer(opts.args)
end, {nargs = 1, complete = 'file'})

@dantleech at the moment it seems to work on simple cases but

* we need to verify if we need the part described in [`workspace/willRenameFiles` - destination file must exist before #2522](https://github.com/phpactor/phpactor/issues/2522) (currently commented out)

* I'm aware that it's badly designed at the moment - I mean using `WorkspaceEdit` directly in `FileRenamer`. Probably we need to define some equivalent of `Phpactor\Rename\Model\LocatedTextEditsMap` instead and convert it to `WorkspaceEdit` in the handler.

At the moment both above things are done:

• replaceDefinition() is needed to edit the source file itself before moving it (in the meaning of WorkspaceEdit changes)
• to avoid reinvention of models and use RenameResult in handler I changed both the adapter and handler into a pattern used in ClassRenamer.

Composing the summarized WorkspaceEdit instance from component instances can be controversial. It assumes (relying on LocatedTextEditConverter::toWorkspaceEdit implementation) that only documentChanges field is not empty in each of them and we can ignore other fields.

https://github.com/phpactor/phpactor/pull/2531/files#diff-39ca8889abb439b22964fc403e2e98d48192ef428529ede2bee62f84221faedfR60-R71

I;d really need to test this against a real client implementation, I initially developed it against the CoC implementation - what implementation is there for NVIM LSP? Is it supported by VS code? What is the end state of this feature from your perspective? how would you use it?

Honestly, at the moment I couldn't think of anything more than that using a simple prompt with path completion to send such request (like the example above) but as a nvim-tree user I could extend it like here

https://github.com/przepompownia/nvim-arctgx/blob/ef3fc1f4221bd82382abf1b5ff973debb415f651/lua/arctgx/pluginConfigs/nvim-tree.lua#L88-L101

I haven't tested it on nvim-oil yet maybe because built-in nvim feature vim.lsp.util.apply_workspace_edit (after recent fixes in master) performs WorkspaceEdit correctly.

Maybe I'll find some free time to install oil.nvim and CoC in separate environments. It's possible that some other clients do not apply RenameResult (but perform it independently) but it seems to be not a reason do skip it in in the response from the server.

The will rename files request is sent from the client to the server before files are actually renamed as long as the rename is triggered from within the client either by a user action or by applying a workspace edit.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_willRenameFiles

Intentionally I didn't merge the recent master here yet because of #2607.

• https://github.com/antosha417/nvim-lsp-file-operations with https://github.com/nvim-tree/nvim-tree.lua works for me as expected on this branch
• oil.nvim uses vim.lsp.util.apply_workspace_edit from Neovim (like in my example command), seems.

I'm confused about why phpstan is complaining about changes unrelated to this PR after merge #2614

Edit: most of them were probably secondary to the few unsilenced.

I've made a PR on your PR: przepompownia#1 would be great if you can verify that it's all working.

Any updates on this? I'd love to have this feature ❤️

Which client are you using that can take advantage of it?

So there's this plugin for neovim at least which integrates with neo-tree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations will try this out soon, sorry for the delay.

There's also https://github.com/stevearc/oil.nvim, that's what I'm using and it has support for this.