Skip to content

Phar build fix - #2281

Merged
dantleech merged 39 commits into
masterfrom
phar-build-fix
May 29, 2023
Merged

dantleech merged 39 commits into
masterfrom
phar-build-fix

Conversation

@dantleech

@dantleech dantleech commented May 29, 2023 •

Copy link
Copy Markdown
Collaborator

Fix file path handling to make Phpactor compatible with a PHAR distribution.

This PR also introduces a development docker-compose.yml to allow the full tooling stack to be executed locally without fuss.

Comment thread lib/Filesystem/Domain/FilePath.php Resolved
@dantleech
dantleech merged commit abbbe22 into master May 29, 2023
@dantleech
dantleech deleted the phar-build-fix branch May 29, 2023 12:12
@dantleech dantleech mentioned this pull request May 29, 2023
Comment thread .github/workflows/ci.yml
- name: Checkout code
uses: actions/checkout@v3
with:
fetch-depth: 0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed ? This will download the whole git history... while only the latest commit is relevant here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, copy/paste from another place, fixed in master

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants