Repository navigation
Adding guide for adding code actions - #2167
Conversation
| code action logic and the provider. | ||
|
|
||
| And then there is the implementation of the `WorseGenerateDecorator` which contains the logic for generating the | ||
| decorator or more generally to apply the code action. |
There was a problem hiding this comment.
I think this needs to be a new document rather than a section here (it seems much more specific than the other things here), so doc/development/language-server/code-action.rst and indeed this document should be broken up and put there too.
But contentfully this looks OK. I realise that the process for creating a code-action is quite intensive currently and could be simplified.
There was a problem hiding this comment.
I have broken up the documentation and added some more to it, about what a code action is and what kinds there are.
|
Looks like I broke the docs, but I have no idea of how RST works, could you give me a hint? |
|
|
||
| Debugging RPC | ||
| ------------- | ||
| ============= |
There was a problem hiding this comment.
this is h1? this should stay as h2 ---- if there is more than one section in the document, only the first header (h1) should use ===
| `lib/WorseReflection/Tests`. | ||
|
|
||
|
|
||
| Profiling the Language Server |
There was a problem hiding this comment.
should be in profiling.rst and it's missing the reference note the build failure and the original text:
.. _developing_blackfire_profiling:
Profiling the Language Server
-----------------------------
|
if you haven't already you can check the |
|
I ran it locally and it said that it was fine. Very strange. |
|
Should be fixed now. |
|
opened a PR against this PR: https://github.com/mamazu/phpactor/pull/2/files :) |
* Move debugging * Update the documentation
|
I have merged it. |
|
Thanks @mamazu we certainly need to improve the docs |
This pull request adds a check list for what is needed when wanting to write a new code action. (because I also forgot that myself after writing the generate decorator).
I am not good at writing documentation, if you need any stylistic changes let me know.