Repository navigation
Improve Completion #1 - #1558
Conversation
dbc8dbf to
480fe10
Compare
|
After this change quick manual tests suggest that I can complete only keywords. |
|
Maybe false alarm - not know why initially did not work (with index built from scratch). |
|
there is one migration issue which i thought i solved: the search index now includes the class type so on an old index it would not find anything if searching for but possible there are some gremlins. certainly needs a full index rebuild to take advantage of the new feature, but should also work similar to before without. |
|
It seems that completion does not work directly after building the index. After starting the server again with the same index created before, completion works. |
|
Reproductible for me: https://asciinema.org/a/dne4pV2RAImoc2EaplPdvmvXI on this example I cannot complete |
|
Looks like NULL was being passed https://github.com/phpactor/phpactor/pull/1561/files |
|
Now completion works just after creating index 👍 |
This PR aims to improve the context sensitivity of completion:
implements=> interfaces,use=> traits,extends=> classesNote that whereas previously we "allowed" completion by default, we now restrict more by default, so its quite likely that completion may stop working in some contexts errornously.