What do you think about this approach?

I started with yielding RenameFile directly but that approach required changing existing objects, creating some new complex or using instanceof.

No unit tests are provided yet.

Some other approaches:

• Return a RenameResult class from Renamer#rename. $result->locatedEdits(); $result->renameOperations()
• Return a RenameResult from the Renamer#rename Generator. foreach ($g as $r) { /.. } $result = $g->getReturn();

Pros/cons:

• A dedicated return type is clean but we lose the benefit of the Generator (which is lost in LSP anyway, so we don't lose anything now)
• If we were using the Generator in a useful way (and due to LSP we are not) Generator#getReturn() would mean getting the "rename" operation after the text edits had been applied.

Indeed, we don't need to modify LocatedTextEdit(s), we can pass rename object(s) directly into the converter.

Maybe LocatedTextEditConverter should be renamed to something more appropriate since it gets Rename.

nice! are you happy to add tests?

Please look at (currently anonymous) NameToUriConverter implementation inside ClassRenamerTest if it is enough or if it's better to use real ClassToFileNameToUriConverter and Workspace.

seems to work great, thanks!

Thanks for support and merging!