Repository navigation
Extract method text edits - #1270
Merged
Merged
Conversation
- Add phpstan's prophecy extension - Remove commented code
Collaborator
Author
|
Replaces #1263 |
dantleech
force-pushed
the
extract-method-text-edits
branch
from
May 15, 2021 12:26
fe80a2d to
7c8a3d0
Compare
Collaborator
Author
|
I get this error in the language server: cc @BladeMF it seems to not error initially, but after so-many-edits it will start doing this consistently. |
Contributor
|
That would indicate that the text edits are wrong. They are calculated in the
How is this test related? Does it reproduce it? |
Collaborator
Author
|
The above issue is roughly caused by CoC providing the entire document a a range when no range is selected - I think I could fix that. Another issue is present with the RPC implementation (possibly because the path is not provided, which is an easy fix) |
Contributor
|
I'd be grateful if you fixed those. |
dantleech
force-pushed
the
extract-method-text-edits
branch
from
May 24, 2021 07:48
63aed63 to
b340050
Compare
phpactor/code-transform b1bed052..f1f349c1
[2021-05-08 09:32:59] f4d4ab09 dantleech Added missing method finder (#49)
[2021-05-08 10:43:44] 855da023 dantleech Improved tests
[2021-05-08 10:44:54] fbb73f5b dantleech Add guard clause
[2021-05-09 14:36:14] fd303bcd dantleech Reflect class-like
[2021-05-14 08:00:56] 36803c7c BladeMF Change ExtractMethod return value ...
[2021-05-21 17:20:11] f1f349c1 BladeMF Fix "Names must have at least one ...
phpactor/code-transform-extension c76913c6..aff7ebc4
[2021-05-08 09:37:43] aff7ebc4 dantleech Add missing method finder
phpactor/language-server-phpactor-extensions 1ca1b27a..cad1ecef
[2021-05-09 13:46:26] aa407451 dantleech Generate method (#40) * WIP gen...
[2021-05-09 14:40:04] bb351376 dantleech Use located document to convert ...
[2021-05-14 08:08:38] f1661d1d dantleech Extract method (#42) * Extract ...
[2021-05-21 17:18:55] 5649880b BladeMF Rename interface and trait (#43)
[2021-05-22 11:54:17] 01bd1a77 BladeMF Detect variables for rename in use...
[2021-05-23 14:54:42] 32c96ac9 dantleech Do not generate `dirty` file
[2021-05-23 21:20:21] db5c6c44 dantleech Import all names (#46) * Extrac...
[2021-05-23 21:41:25] cad1ecef dantleech Fix performance issue
phpactor/text-document 3a8faef4..962070cb
[2021-05-24 07:37:23] 962070cb dantleech Do not throw exception on out of...
phpactor/worse-reference-finders e3cec3b2..2685e4e0
[2021-05-21 17:19:37] 2685e4e0 BladeMF Fix variable reference in catch cl...
phpactor/worse-reflection ba68c3e8..d27f9dc2
[2021-05-09 12:53:43] c6382629 dantleech Fix progress logger
[2021-05-09 12:59:19] 159d404f dantleech Force ANSI
[2021-05-22 11:53:33] d27f9dc2 BladeMF Tolerate empty use statements and ...
phpactor/code-transform b1bed052..f1f349c1
[2021-05-08 09:32:59] f4d4ab09 dantleech Added missing method finder (#49)
[2021-05-08 10:43:44] 855da023 dantleech Improved tests
[2021-05-08 10:44:54] fbb73f5b dantleech Add guard clause
[2021-05-09 14:36:14] fd303bcd dantleech Reflect class-like
[2021-05-14 08:00:56] 36803c7c BladeMF Change ExtractMethod return value ...
[2021-05-21 17:20:11] f1f349c1 BladeMF Fix "Names must have at least one ...
phpactor/code-transform-extension c76913c6..aff7ebc4
[2021-05-08 09:37:43] aff7ebc4 dantleech Add missing method finder
phpactor/language-server-phpactor-extensions 1ca1b27a..cad1ecef
[2021-05-09 13:46:26] aa407451 dantleech Generate method (#40) * WIP gen...
[2021-05-09 14:40:04] bb351376 dantleech Use located document to convert ...
[2021-05-14 08:08:38] f1661d1d dantleech Extract method (#42) * Extract ...
[2021-05-21 17:18:55] 5649880b BladeMF Rename interface and trait (#43)
[2021-05-22 11:54:17] 01bd1a77 BladeMF Detect variables for rename in use...
[2021-05-23 14:54:42] 32c96ac9 dantleech Do not generate `dirty` file
[2021-05-23 21:20:21] db5c6c44 dantleech Import all names (#46) * Extrac...
[2021-05-23 21:41:25] cad1ecef dantleech Fix performance issue
phpactor/text-document 3a8faef4..962070cb
[2021-05-24 07:37:23] 962070cb dantleech Do not throw exception on out of...
phpactor/worse-reference-finders e3cec3b2..2685e4e0
[2021-05-21 17:19:37] 2685e4e0 BladeMF Fix variable reference in catch cl...
phpactor/worse-reflection ba68c3e8..d27f9dc2
[2021-05-09 12:53:43] c6382629 dantleech Fix progress logger
[2021-05-09 12:59:19] 159d404f dantleech Force ANSI
[2021-05-22 11:53:33] d27f9dc2 BladeMF Tolerate empty use statements and ...
phpactor/code-transform b1bed052..f1f349c1
[2021-05-08 09:32:59] f4d4ab09 dantleech Added missing method finder (#49)
[2021-05-08 10:43:44] 855da023 dantleech Improved tests
[2021-05-08 10:44:54] fbb73f5b dantleech Add guard clause
[2021-05-09 14:36:14] fd303bcd dantleech Reflect class-like
[2021-05-14 08:00:56] 36803c7c BladeMF Change ExtractMethod return value ...
[2021-05-21 17:20:11] f1f349c1 BladeMF Fix "Names must have at least one ...
phpactor/code-transform-extension c76913c6..aff7ebc4
[2021-05-08 09:37:43] aff7ebc4 dantleech Add missing method finder
phpactor/language-server-phpactor-extensions 1ca1b27a..cad1ecef
[2021-05-09 13:46:26] aa407451 dantleech Generate method (#40) * WIP gen...
[2021-05-09 14:40:04] bb351376 dantleech Use located document to convert ...
[2021-05-14 08:08:38] f1661d1d dantleech Extract method (#42) * Extract ...
[2021-05-21 17:18:55] 5649880b BladeMF Rename interface and trait (#43)
[2021-05-22 11:54:17] 01bd1a77 BladeMF Detect variables for rename in use...
[2021-05-23 14:54:42] 32c96ac9 dantleech Do not generate `dirty` file
[2021-05-23 21:20:21] db5c6c44 dantleech Import all names (#46) * Extrac...
[2021-05-23 21:41:25] cad1ecef dantleech Fix performance issue
phpactor/text-document 3a8faef4..962070cb
[2021-05-24 07:37:23] 962070cb dantleech Do not throw exception on out of...
phpactor/worse-reference-finders e3cec3b2..2685e4e0
[2021-05-21 17:19:37] 2685e4e0 BladeMF Fix variable reference in catch cl...
phpactor/worse-reflection ba68c3e8..d27f9dc2
[2021-05-09 12:53:43] c6382629 dantleech Fix progress logger
[2021-05-09 12:59:19] 159d404f dantleech Force ANSI
[2021-05-22 11:53:33] d27f9dc2 BladeMF Tolerate empty use statements and ...
dantleech
force-pushed
the
extract-method-text-edits
branch
from
May 24, 2021 07:57
b9081db to
3a5776c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.