Skip to content

Ensure workspace is indexed when finding references - #1237

Merged
dantleech merged 1 commit into
masterfrom
workspace-reference
Apr 17, 2021
Merged

dantleech merged 1 commit into
masterfrom
workspace-reference

Conversation

@dantleech

@dantleech dantleech commented Apr 17, 2021 •

Copy link
Copy Markdown
Collaborator

This PR fixes the inconsistent rename behavior in the LSP caused by the on-disk index becoming out-of-sync with the in-memory document changes (the LSP renamer doesn't commit the renames to disk immediately).

  • Before renmaing the in-memory documents will be indexed to the disk.
  • These documents will be recorded as being "dirty"
  • "dirty" documents will be re-indexed when the LS starts or the index is explicitly built.

cc @BladeMF

  phpactor/indexer-extension 4e4e1abd..bca3ea5e

    [2021-04-17 11:22:15] ef8715df dantleech Dirty file tracking (#42)  * Refactor to use text document    * Added dirty document tracker    * Added dirty file...
    [2021-04-17 11:37:55] 59f74323 dantleech Update dphpbench config
    [2021-04-17 11:46:53] d3dad532 dantleech Plin
    [2021-04-17 11:54:17] bca3ea5e dantleech Do not use seconds unit

  phpactor/language-server-phpactor-extensions 0b9d4a1a..f7f3ccd0

    [2021-04-17 11:17:40] e6f75300 dantleech Add workspace update reference finder
    [2021-04-17 11:32:49] 7044192e dantleech Use workspace updating reference finder
    [2021-04-17 11:35:50] 3058ddc4 dantleech Update API
    [2021-04-17 12:47:43] f7f3ccd0 dantleech Ensure workspace index gets indexed when finding references

  phpactor/worse-reference-finder-extension 6f111040..3b8b6766

    [2021-04-17 12:44:52] 3b8b6766 dantleech Inject cache

  phpactor/worse-reference-finders 93651efd..d33b2fb5

    [2021-04-17 12:42:25] d33b2fb5 dantleech Purge cache on definition location request

  phpactor/worse-reflection a815e176..faf4362c

    [2021-04-17 12:25:01] faf4362c dantleech Allow cache to be injected  Add cache purge method  Add purge method  Removed junk files  Fix CS

  phpactor/worse-reflection-extension 8a4adba3..7e626bb0

    [2021-04-17 12:39:05] 5c5ca0f1 dantleech Allow Cache to be accessed (and purged)
    [2021-04-17 12:40:05] 7e626bb0 dantleech Update cs fixer

  phpbench/phpbench 38848aff..d3262826

    [2021-04-13 14:40:41] 32e7b2f4 dantleech Renaming (#808)  * Make runner param names consistent (also fix test output)    * Extracted console extension    *...
    [2021-04-13 15:30:46] 8c4d958f dantleech Imporve expr errors in report (#809)  * Updated console logger to use output    * Fix CS
    [2021-04-13 15:31:36] d3262826 dantleech Bumped changelog

  phpactor/completion 2347168e..8738fb5a

    [2021-04-16 07:19:15] 65acbfd1 weeman1337 fix expected class completion description (#51)  * fix expected class completion description    The PhpStorm stub...
    [2021-04-16 07:21:37] 33f50ce0 dantleech Updated PHPBench conifg
    [2021-04-16 07:23:36] 8738fb5a dantleech FIx script

  phpactor/indexer-extension 4e4e1abd..bca3ea5e

    [2021-04-17 11:22:15] ef8715df dantleech Dirty file tracking (#42)  * Refactor to use text document    * Added dirty document tracker    * Added dirty file...
    [2021-04-17 11:37:55] 59f74323 dantleech Update dphpbench config
    [2021-04-17 11:46:53] d3dad532 dantleech Plin
    [2021-04-17 11:54:17] bca3ea5e dantleech Do not use seconds unit

  phpactor/language-server-phpactor-extensions 0b9d4a1a..f7f3ccd0

    [2021-04-17 11:17:40] e6f75300 dantleech Add workspace update reference finder
    [2021-04-17 11:32:49] 7044192e dantleech Use workspace updating reference finder
    [2021-04-17 11:35:50] 3058ddc4 dantleech Update API
    [2021-04-17 12:47:43] f7f3ccd0 dantleech Ensure workspace index gets indexed when finding references

  phpactor/worse-reference-finder-extension 6f111040..3b8b6766

    [2021-04-17 12:44:52] 3b8b6766 dantleech Inject cache

  phpactor/worse-reference-finders 93651efd..d33b2fb5

    [2021-04-17 12:42:25] d33b2fb5 dantleech Purge cache on definition location request

  phpactor/worse-reflection a815e176..faf4362c

    [2021-04-17 12:25:01] faf4362c dantleech Allow cache to be injected  Add cache purge method  Add purge method  Removed junk files  Fix CS

  phpactor/worse-reflection-extension 8a4adba3..7e626bb0

    [2021-04-17 12:39:05] 5c5ca0f1 dantleech Allow Cache to be accessed (and purged)
    [2021-04-17 12:40:05] 7e626bb0 dantleech Update cs fixer

  phpbench/phpbench 38848aff..d3262826

    [2021-04-13 14:40:41] 32e7b2f4 dantleech Renaming (#808)  * Make runner param names consistent (also fix test output)    * Extracted console extension    *...
    [2021-04-13 15:30:46] 8c4d958f dantleech Imporve expr errors in report (#809)  * Updated console logger to use output    * Fix CS
    [2021-04-13 15:31:36] d3262826 dantleech Bumped changelog
@dantleech
dantleech force-pushed the workspace-reference branch from ddefc80 to 5265043 Compare April 17, 2021 12:57
@dantleech
dantleech merged commit bbf4dce into master Apr 17, 2021
@dantleech
dantleech deleted the workspace-reference branch April 17, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant