Skip to content

Support for renaming variables and class members in LS - #1231

Merged
dantleech merged 3 commits into
masterfrom
rename
Apr 11, 2021
Merged

dantleech merged 3 commits into
masterfrom
rename

Conversation

@dantleech

Copy link
Copy Markdown
Collaborator
dantleech/what-changed: 4 updated

  phpactor/language-server-phpactor-extensions 86821ac0..1e8f8f08

    [2021-04-11 10:00:45] b5715429 dantleech Enable the renamer
    [2021-04-11 10:50:09] 33ec18b0 dantleech Extract renamer implementations to extnsion
    [2021-04-11 11:17:41] 4978c7c7 dantleech Offset Extractor imporvements (#32)  * Extracted result object    * Support range ...
    [2021-04-11 21:49:20] 1e8f8f08 dantleech Member rename (#33)  * Adding support for member rename    * Connect the member re...

  phpactor/reference-finder 67106214..754f5b12

    [2021-04-11 12:10:38] cbc919ea dantleech Added aggregate definition and reference finder
    [2021-04-11 12:11:29] 754f5b12 dantleech Allow risky

  phpactor/worse-reference-finder-extension 05b4fdef..6f111040

    [2021-04-11 20:34:24] 6f111040 dantleech Add dedicated variable location finder

  phpactor/worse-reference-finders 47cce535..93651efd

    [2021-04-11 20:28:53] 2195d640 dantleech Use variable reference finder to find definition
    [2021-04-11 20:30:29] 1e604f4a dantleech Make include definition optional
    [2021-04-11 20:30:45] 9b56a983 dantleech CS fix
    [2021-04-11 20:56:00] 93651efd dantleech Variable reference finder uses correct param offset

dantleech/what-changed: 4 updated

  phpactor/language-server-phpactor-extensions 86821ac0..1e8f8f08

    [2021-04-11 10:00:45] b5715429 dantleech Enable the renamer
    [2021-04-11 10:50:09] 33ec18b0 dantleech Extract renamer implementations to extnsion
    [2021-04-11 11:17:41] 4978c7c7 dantleech Offset Extractor imporvements (#32)  * Extracted result object    * Support range ...
    [2021-04-11 21:49:20] 1e8f8f08 dantleech Member rename (#33)  * Adding support for member rename    * Connect the member re...

  phpactor/reference-finder 67106214..754f5b12

    [2021-04-11 12:10:38] cbc919ea dantleech Added aggregate definition and reference finder
    [2021-04-11 12:11:29] 754f5b12 dantleech Allow risky

  phpactor/worse-reference-finder-extension 05b4fdef..6f111040

    [2021-04-11 20:34:24] 6f111040 dantleech Add dedicated variable location finder

  phpactor/worse-reference-finders 47cce535..93651efd

    [2021-04-11 20:28:53] 2195d640 dantleech Use variable reference finder to find definition
    [2021-04-11 20:30:29] 1e604f4a dantleech Make include definition optional
    [2021-04-11 20:30:45] 9b56a983 dantleech CS fix
    [2021-04-11 20:56:00] 93651efd dantleech Variable reference finder uses correct param offset
@dantleech

Copy link
Copy Markdown
Collaborator Author

Renaming property definitions doesn't work

@dantleech
dantleech merged commit eb563d0 into master Apr 11, 2021
@dantleech
dantleech deleted the rename branch April 11, 2021 22:16
@BladeMF

BladeMF commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

My code only addressed variables.

@dantleech

dantleech commented Apr 13, 2021 •

Copy link
Copy Markdown
Collaborator Author

yep, this is a different PR. the comment is addresssed to myself 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants