Repository navigation
Conversation
dantleech
commented
Apr 11, 2021
Collaborator
dantleech/what-changed: 4 updated
phpactor/language-server-phpactor-extensions 86821ac0..1e8f8f08
[2021-04-11 10:00:45] b5715429 dantleech Enable the renamer
[2021-04-11 10:50:09] 33ec18b0 dantleech Extract renamer implementations to extnsion
[2021-04-11 11:17:41] 4978c7c7 dantleech Offset Extractor imporvements (#32) * Extracted result object * Support range ...
[2021-04-11 21:49:20] 1e8f8f08 dantleech Member rename (#33) * Adding support for member rename * Connect the member re...
phpactor/reference-finder 67106214..754f5b12
[2021-04-11 12:10:38] cbc919ea dantleech Added aggregate definition and reference finder
[2021-04-11 12:11:29] 754f5b12 dantleech Allow risky
phpactor/worse-reference-finder-extension 05b4fdef..6f111040
[2021-04-11 20:34:24] 6f111040 dantleech Add dedicated variable location finder
phpactor/worse-reference-finders 47cce535..93651efd
[2021-04-11 20:28:53] 2195d640 dantleech Use variable reference finder to find definition
[2021-04-11 20:30:29] 1e604f4a dantleech Make include definition optional
[2021-04-11 20:30:45] 9b56a983 dantleech CS fix
[2021-04-11 20:56:00] 93651efd dantleech Variable reference finder uses correct param offset
Collaborator
Author
|
Renaming property definitions doesn't work |
Contributor
|
My code only addressed variables. |
Collaborator
Author
|
yep, this is a different PR. the comment is addresssed to myself 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.