Skip to content

Add configurable root directory strategies - #1027

Merged
dantleech merged 6 commits into
phpactor:developfrom
przepompownia:root-directory-strategies
May 7, 2020
Merged

dantleech merged 6 commits into
phpactor:developfrom
przepompownia:root-directory-strategies

Conversation

@przepompownia

Copy link
Copy Markdown
Contributor

No description provided.

@przepompownia

Copy link
Copy Markdown
Contributor Author

Closes #959
#959 (review)

@przepompownia przepompownia changed the title Root directory strategies Add configurable root directory strategies May 4, 2020
@przepompownia

Copy link
Copy Markdown
Contributor Author

https://github.com/przepompownia/vim-project still needs some work but can be used to test.

@przepompownia

Copy link
Copy Markdown
Contributor Author

Failed test remembers about upgrading minimal vim requirements:
vim/vim@069c1e7

@dantleech

dantleech commented May 5, 2020 •

Copy link
Copy Markdown
Collaborator

Happy to set min version to 8

@przepompownia

Copy link
Copy Markdown
Contributor Author

The last commit uses unofficial ppa:jonathonf/vim repository. I am not sure if it is a good idea. We (assuming using Travis) could build vim from source but it probably would occur each time.

@dantleech

dantleech commented May 6, 2020 •

Copy link
Copy Markdown
Collaborator

I am not sure if it is a good idea.

What's the worst that could happen?


This looks good - what would be the next steps if any? Perhaps add documentation to integrate with root-finding packages(?)?

@przepompownia

Copy link
Copy Markdown
Contributor Author

I think that in worst case we will have to build vim from source (it takes time and resources) or change Travis to something more flexible (Travis seems to have limited choice of docker images).

I would like to add a documentation howto integrate it with external tools (in addition to the existing with global variables declarations). What do you think about doing it in a separate PR and merge this as is (eventually with other fixes)? Currently it works without any BC break.

I need some time to complete documentation in vim-project and (before) decide how to expose abstraction instead of referencing to b:project (that probably should be internal).

If i had to document an integration with vim-rooter, I also need some time to test. Both things could be done with separate PR-s.

@dantleech

Copy link
Copy Markdown
Collaborator

Sounds good 👍

@dantleech
dantleech merged commit 266e8f5 into phpactor:develop May 7, 2020
@przepompownia
przepompownia deleted the root-directory-strategies branch May 7, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants