Skip to content

Goto Implementation should work on class members. #931

Closed

Description

@dantleech

e.g.

$this->foobarClient->doSo<>mething()

if foobarClient is an interface then invoking PhpactorGotoimplementations on <> should if there is a single implementation it should be opened and the cursor moved to the method (as with goto definition).

If multiple implementations, perhaps we can preserve the method name and still goto the method position after selection.

Activity

  1. camilledejoye commented on Apr 24, 2020

    @camilledejoye
    Contributor

    If multiple implementations, perhaps we can preserve the method name and still goto the method position after selection.

    Are we still talking about LSP ?
    If it's for the RPC then I guess we don't even have to remember anything since the reference hold the position information.

  2. dantleech commented on Apr 24, 2020

    @dantleech
    CollaboratorAuthor

    Ideally it would work behind the abstraction (not sure about this), so not related to LSP / RPC. We would need to resolve the container class of the member, find implementation(s) of that, then open that file at the position of the method implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions