You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Goto Implementation should work on class members. #931
if foobarClient is an interface then invoking PhpactorGotoimplementations on <> should if there is a single implementation it should be opened and the cursor moved to the method (as with goto definition).
If multiple implementations, perhaps we can preserve the method name and still goto the method position after selection.
If multiple implementations, perhaps we can preserve the method name and still goto the method position after selection.
Are we still talking about LSP ?
If it's for the RPC then I guess we don't even have to remember anything since the reference hold the position information.
Ideally it would work behind the abstraction (not sure about this), so not related to LSP / RPC. We would need to resolve the container class of the member, find implementation(s) of that, then open that file at the position of the method implementation.
Activity
camilledejoye commentedon Apr 24, 2020
Are we still talking about LSP ?
If it's for the RPC then I guess we don't even have to remember anything since the reference hold the position information.
dantleech commentedon Apr 24, 2020
Ideally it would work behind the abstraction (not sure about this), so not related to LSP / RPC. We would need to resolve the container class of the member, find implementation(s) of that, then open that file at the position of the method implementation.