Skip to content

Refactoring a static member variable forgets $ sign #926

Closed

Description

@greg0ire

I'm trying to make this file comply with the Doctrine coding standards: https://github.com/doctrine/sql-formatter/blob/master/src/SqlFormatter.php

Workflow:

  1. hover static member variable
  2. :call phpactor#ContextMenu()
  3. replace references

I end up with the following result

class A
{
    private static $renamed;

    public function foo()
    {
         self::renamed = 'a'; // $ sign misses after refactoring
    }

Activity

  1. added 2 commits that reference this issue on Mar 22, 2020
    9ab8330
    384a010
  2. dantleech commented on Mar 23, 2020

    @dantleech
    Collaborator

    Should work in develop now...

  3. greg0ire commented on Mar 23, 2020

    @greg0ire
    ContributorAuthor

    Thanks!

  4. added a commit that references this issue on May 3, 2020
    4fa2345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions