You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Goto Implementation(s): Unusably slow in large projects and opinionated (depends on naming conventions to filter)
The async FZF list implementation breaks the callback system of the menu - there is currently a dirty hack to work around this. edit: Have made this functionality experimental.
For the "goto implementation" I think it's OK to include it in the release as long as it's well documented that the feature is slow on large project.
I often use ripgrep instead but in some cases I'm willing to take a few minutes to have a better result with this feature.
As long as it doesn't break anything, the user can choose to not use it so it's OK for me.
For the FZF list, I will try to get a look at it, we might have to change a few things or at least not use it for features that returns a list of actions.
I have a pretty good solution for goto implementation - using a lazy index. However I'm currently blocked with the "cs fixer" implementation in code-builder - as it really doesn't work very well. I may well revert that completely and just live with the existing poorly formatted code.
I don't think so - it's very time consuming to setup and I haven't got confidence in any particular plan. I'd rather not add further tasks to the list.
Hae added PHP version detection which also checks composer and improved the workspace-queryindexer to support a basic --watch mode.
In addition to enabling goto implementation the workspace-query module also proides source code location - which will provide much better support for non-composer / strange projects / projects which break autoloaders.
It's still experimental though, the indexer is polling currently which means scanning potentially ~30k files every x seconds - it should at least support using inotify on Linux-like machines. In addition the VIM plugin should be able to manage the process and keep it running - and that's interesting as VIM and Nvim have different APIs. Probably better to delegate to a third-party plugin if available.
Would also to allow the use of > 1 core when using the indexer...
So potentially will keep workspace-query experimental.
Activity
camilledejoye commentedon Feb 5, 2020
For the "goto implementation" I think it's OK to include it in the release as long as it's well documented that the feature is slow on large project.
I often use ripgrep instead but in some cases I'm willing to take a few minutes to have a better result with this feature.
As long as it doesn't break anything, the user can choose to not use it so it's OK for me.
For the FZF list, I will try to get a look at it, we might have to change a few things or at least not use it for features that returns a list of actions.
dantleech commentedon Feb 5, 2020
I have a pretty good solution for goto implementation - using a lazy index. However I'm currently blocked with the "cs fixer" implementation in code-builder - as it really doesn't work very well. I may well revert that completely and just live with the existing poorly formatted code.
camilledejoye commentedon Feb 5, 2020
I think it's acceptable, the "poorly formated code" was only in some really specific cases if I remember properly.
camilledejoye commentedon Feb 6, 2020
Do you think it would be possible to use the monolith for the next release ?
dantleech commentedon Feb 6, 2020
I don't think so - it's very time consuming to setup and I haven't got confidence in any particular plan. I'd rather not add further tasks to the list.
dantleech commentedon Feb 8, 2020
The CS fixer (for generated code) has been completely removed now. Will hopefully get the indexer finished tomorrow.
dantleech commentedon Feb 9, 2020
@elythyr I made a PR to make the FZF / BAT features experimental for this release: #883
dantleech commentedon Feb 15, 2020
Hae added PHP version detection which also checks composer and improved the
workspace-queryindexer to support a basic--watchmode.In addition to enabling
goto implementationthe workspace-query module also proides source code location - which will provide much better support for non-composer / strange projects / projects which break autoloaders.It's still experimental though, the indexer is polling currently which means scanning potentially ~30k files every x seconds - it should at least support using
inotifyon Linux-like machines. In addition the VIM plugin should be able to manage the process and keep it running - and that's interesting as VIM and Nvim have different APIs. Probably better to delegate to a third-party plugin if available.Would also to allow the use of > 1 core when using the indexer...
So potentially will keep workspace-query experimental.
camilledejoye commentedon Feb 25, 2020
It's indeed to possible to find third-party plugin to deal with async in both Vim and NVim.
dantleech commentedon Feb 25, 2020
Well, it's fairly trivial to do it ourselves (and stay dependency-less) I think (this is the WIP)
dantleech commentedon Mar 1, 2020
One month late: https://www.dantleech.com/blog/2020/03/01/phpactor-14/
... and there was much rejoicing 🎉