Skip to content

Release 14 by February 1st #868

Closed
Closed

Description

@dantleech

There are quite some changes in develop currently, and some of them are problematic and blocking the next release:

We should consider reverting the above if they cannot be fixed.

In addition it would be great to:

Anything else I'm missing? cc @elythyr @einenlum

Activity

  1. camilledejoye commented on Feb 5, 2020

    @camilledejoye
    Contributor

    For the "goto implementation" I think it's OK to include it in the release as long as it's well documented that the feature is slow on large project.
    I often use ripgrep instead but in some cases I'm willing to take a few minutes to have a better result with this feature.
    As long as it doesn't break anything, the user can choose to not use it so it's OK for me.

    For the FZF list, I will try to get a look at it, we might have to change a few things or at least not use it for features that returns a list of actions.

  2. dantleech commented on Feb 5, 2020

    @dantleech
    CollaboratorAuthor

    I have a pretty good solution for goto implementation - using a lazy index. However I'm currently blocked with the "cs fixer" implementation in code-builder - as it really doesn't work very well. I may well revert that completely and just live with the existing poorly formatted code.

  3. camilledejoye commented on Feb 5, 2020

    @camilledejoye
    Contributor

    I think it's acceptable, the "poorly formated code" was only in some really specific cases if I remember properly.

  4. camilledejoye commented on Feb 6, 2020

    @camilledejoye
    Contributor

    Do you think it would be possible to use the monolith for the next release ?

  5. dantleech commented on Feb 6, 2020

    @dantleech
    CollaboratorAuthor

    I don't think so - it's very time consuming to setup and I haven't got confidence in any particular plan. I'd rather not add further tasks to the list.

  6. dantleech commented on Feb 8, 2020

    @dantleech
    CollaboratorAuthor

    The CS fixer (for generated code) has been completely removed now. Will hopefully get the indexer finished tomorrow.

  7. dantleech commented on Feb 9, 2020

    @dantleech
    CollaboratorAuthor

    @elythyr I made a PR to make the FZF / BAT features experimental for this release: #883

  8. dantleech commented on Feb 15, 2020

    @dantleech
    CollaboratorAuthor

    Hae added PHP version detection which also checks composer and improved the workspace-query indexer to support a basic --watch mode.

    In addition to enabling goto implementation the workspace-query module also proides source code location - which will provide much better support for non-composer / strange projects / projects which break autoloaders.

    It's still experimental though, the indexer is polling currently which means scanning potentially ~30k files every x seconds - it should at least support using inotify on Linux-like machines. In addition the VIM plugin should be able to manage the process and keep it running - and that's interesting as VIM and Nvim have different APIs. Probably better to delegate to a third-party plugin if available.

    Would also to allow the use of > 1 core when using the indexer...

    So potentially will keep workspace-query experimental.

  9. camilledejoye commented on Feb 25, 2020

    @camilledejoye
    Contributor

    It's indeed to possible to find third-party plugin to deal with async in both Vim and NVim.

  10. dantleech commented on Feb 25, 2020

    @dantleech
    CollaboratorAuthor

    Well, it's fairly trivial to do it ourselves (and stay dependency-less) I think (this is the WIP)

  11. dantleech commented on Mar 1, 2020

    @dantleech
    CollaboratorAuthor

    One month late: https://www.dantleech.com/blog/2020/03/01/phpactor-14/

    ... and there was much rejoicing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions