Skip to content

Can it import class name inline (for vim) #867

Closed

Description

@QzCurious

I don't know if it only me wanting a way to transform a class name to its full name. And I think phpactor must good enough to do so. After seeking issues a few time. I found the functionality was asked and implemented before!!

At this moment, I'm wondering if we, vim users, should dive into the code to explore how amaze it is. Or it's just accidentally lost its description. Hope these functionality can be described in the site.

After all, I'm don't want to be offensive to ask adding description for everything we can do with it, but want this project can be used efficiently by everyone.

Activity

  1. dantleech commented on Jan 11, 2020

    @dantleech
    Collaborator

    Hi - yes you're correct. This isn't documented on the site currently - it's actually a VIM plugin only feature, would it make sense to add the shortcut to the example mappings?

    nmap <Leader>e :call phpactor#ClassExpand()<CR>
    

    and add it to the refactorings page?

    Feel free to open a pull request :)

  2. QzCurious commented on Jan 11, 2020

    @QzCurious
    ContributorAuthor

    I've made a Expand Class section in doc. And I alse modify the code that add a leading \ to the result of class name to match the definition of fully qualified name. REFUSED
    I'd like to know which branch should I make a pull request to, master or develop?

    For the reason that why I just add a leading \ instead of made a parameter to make it optional is that I think this is a facility but not dependency.

  3. dantleech commented on Jan 11, 2020

    @dantleech
    Collaborator

    Great! "develop" is the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions